Do not stop checking DataView properties on first failure #47
Conversation
|
Thanks, this helped |
|
@MarkCDavid Thanks a lot! I also stumbled upon this after freshly installing Graph Links Types and scratching my head on why it didn't work... @natefrisch01 Thank you for the great plugin! Would you be able to merge this fix so that new users do not hit this roadblock in the future? Thanks! |
Instead of continuing, break out of the switch context and allow the loop to continue "naturally". Co-authored-by: Lukas Waslowski <[email protected]>
|
I too just hit this problem. If I go to a note where things aren't working... if I delete the headers and a lot of the text, it starts working and adding everything back leaves everything operational. Does that help? Also... @MarkCDavid , it seems you may have found a solution that was approved by @cr7pt0gr4ph7 ? Can I install aversion from your branch? |
|
I have the same issue and it's quite frustrating after I spent an afternoon figuring out why it just doesn't work. |
|
I've tried to include this change on my fork here https://github.com/CHerSun/Graph-Link-Types . In the fork I've tried to do the upkeeping work - bumped package versions, added automatic pipeline to build release and bump plugin versions, but my knowledge in JS/TS is definitely lacking to actualize the code itself. I'd appreciate the help to revive the plugin and maybe extend functionality. Plugin from my fork can be added via BRAT using the github link. |
6 participants
A small fix for the following situation:
When iterating through the DataView properties, previously, the code would see that the metadata property
what_is_thisis not a link and would stop immediately. If we allow for it to continue, instead of stopping, it will checkwhat_is_thatproperty, return it as intended and render the link correctly.The fix here allows for consideration across all DataView properties, as such, we can have DataView properties with a link and ones without a link together.